Open
Conversation
34d4abc to
bcef4c4
Compare
4ea9e90 to
18d6f87
Compare
Signed-off-by: Julius Knorr <jus@bitgrid.net>
Signed-off-by: Julius Knorr <jus@bitgrid.net>
18d6f87 to
8e22c19
Compare
Member
|
Code changes look good to me, but I don't see the ConfigLexicon class being used anywhere. Also I don't know the concept of a ConfigLexicon yet. Can I read up somewhere about its purpose? |
Member
Author
mejo-
reviewed
Jan 29, 2026
Member
mejo-
left a comment
There was a problem hiding this comment.
Thanks for the extra pointers @juliusknorr. I have some nitpicking comments about the wording of the descriptions. If you agree with the suggested changes, I can also take care of them to not put more work on your shoulders.
| key: 'default_file_extension', | ||
| type: ValueType::STRING, | ||
| defaultRaw: 'md', | ||
| definition: 'Default file extension for new text files', |
Member
There was a problem hiding this comment.
Suggested change
| definition: 'Default file extension for new text files', | |
| definition: 'Default file extension for new text files (usually \'md\' or \'txt\')', |
| key: 'open_read_only_enabled', | ||
| type: ValueType::BOOL, | ||
| defaultRaw: false, | ||
| definition: 'Whether opening files in read-only mode is enabled', |
Member
There was a problem hiding this comment.
Suggested change
| definition: 'Whether opening files in read-only mode is enabled', | |
| definition: 'Whether files are opened in read-only mode per default', |
| key: 'workspace_available', | ||
| type: ValueType::BOOL, | ||
| defaultRaw: true, | ||
| definition: 'Whether rich workspace feature is available', |
Member
There was a problem hiding this comment.
Suggested change
| definition: 'Whether rich workspace feature is available', | |
| definition: 'Whether folder description feature (previously called rich workspace) is available', |
| key: 'notify_push', | ||
| type: ValueType::BOOL, | ||
| defaultRaw: true, | ||
| definition: 'Whether notify_push synchronization is enabled', |
Member
There was a problem hiding this comment.
Suggested change
| definition: 'Whether notify_push synchronization is enabled', | |
| definition: 'Whether notify_push is used for real-time synchronization if available', |
| key: 'workspace_enabled', | ||
| type: ValueType::BOOL, | ||
| defaultRaw: true, | ||
| definition: 'Whether rich workspace is enabled for the user', |
Member
There was a problem hiding this comment.
Suggested change
| definition: 'Whether rich workspace is enabled for the user', | |
| definition: 'Whether folder description feature (previously called rich workspace) is enabled for the user', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This properly defines possible config options we have
nextcloud/documentation#12982 for some more information on the concept