fix(DocumentService): Return 200 steps before saved version in SyncStep2#7703
Merged
max-nextcloud merged 1 commit intomainfrom Oct 7, 2025
Merged
fix(DocumentService): Return 200 steps before saved version in SyncStep2#7703max-nextcloud merged 1 commit intomainfrom
max-nextcloud merged 1 commit intomainfrom
Conversation
When replying to a SyncStep1, which the client sends if it detected a missing step, we now add the 200 steps before the last saved version. This is done to workaround race conditions where the state with the missing step got persisted in the document state. See #7692 Signed-off-by: Jonas <jonas@freesources.org>
0306d76 to
87098ae
Compare
max-nextcloud
approved these changes
Oct 7, 2025
Collaborator
|
/backport to stable32 |
Collaborator
|
/backport to stable31 |
This was referenced Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When replying to a SyncStep1, which the client sends if it detected a missing step, we now add the 200 steps before the last saved version.
This is done to workaround race conditions where the state with the missing step got persisted in the document state.
See #7692
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)