[stable31] fix(workspace): toggle right away and only render if needed#7506
Merged
[stable31] fix(workspace): toggle right away and only render if needed#7506
Conversation
4fe5451 to
2f3e74c
Compare
mejo-
approved these changes
Jul 30, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stable31 #7506 +/- ##
=========================================
Coverage 51.54% 51.55%
=========================================
Files 292 292
Lines 41472 41470 -2
Branches 875 875
=========================================
+ Hits 21377 21378 +1
+ Misses 19974 19971 -3
Partials 121 121 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Awaiting the request for the file lead to race conditions: * Enter directory with rich workspace, loading is triggered. * Navigate to directory without rich workspace. * Loading finishes - rich workspace was shown. Also clean up some minor things: * `this.creating` was not used at all. * The Editor does not emit `error`. Signed-off-by: Max <max@nextcloud.com>
The header is just hidden if enabled is false. But for the workspace this leads to continuous requests updating the content. Signed-off-by: Max <max@nextcloud.com>
2f3e74c to
8d03b62
Compare
skjnldsv
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #7501
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.