fix(link): Don't throw exception on invalid URL href#6794
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6794 +/- ##
==========================================
+ Coverage 46.86% 46.89% +0.02%
==========================================
Files 747 732 -15
Lines 34080 34065 -15
Branches 1240 1226 -14
==========================================
+ Hits 15973 15976 +3
+ Misses 17486 17483 -3
+ Partials 621 606 -15 ☔ View full report in Codecov by Sentry. |
Member
Author
|
/backport to stable30 |
Member
Author
|
/backport to stable29 |
juliusknorr
approved these changes
Dec 17, 2024
src/marks/Link.js
Outdated
| ? domHref(mark, this.options.relativePath) | ||
| : '#' | ||
| } catch (error) { | ||
| href = mark.attrs.href |
Collaborator
There was a problem hiding this comment.
I'd also fall back to '#' here as we have no way of checking if this is a protocol we actually want to link to.
Collaborator
|
The Reuse check failure is really odd... looks like there are some licenses we sometimes use and sometimes don't. |
When pasting strings with invalid URLs, `new URL()` in `renderHTML()` of the Link extension threw an error, which made the paste parser choke. We should catch this exception and handle it gracefully to not break HTML parsing completely with invalid URLs. Signed-off-by: Jonas <jonas@freesources.org>
6b7e145 to
d182756
Compare
This was referenced Dec 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When pasting strings with invalid URLs,
new URL()inrenderHTML()of the Link extension threw an error, which made the paste parser choke.We should catch this exception and handle it gracefully to not break HTML parsing completely with invalid URLs.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)