Merged
Conversation
max-nextcloud
approved these changes
Jul 28, 2023
Collaborator
max-nextcloud
left a comment
There was a problem hiding this comment.
🎉
Wow! So little changes - so much impact!
Fixes: #3618 Also only load core highlight JS package in EditorFactory.js (required for syntax highlighting in plaintext editing). This reduces the size ofr compiled editor.js by almost 1MB. Signed-off-by: Jonas <[email protected]>
85399cc to
f1a0fea
Compare
Collaborator
|
/compile |
Member
Author
|
/backport f1a0fea to stable26 |
Member
Author
|
/backport f1a0fea to stable27 |
Signed-off-by: nextcloud-command <[email protected]>
1 flaky tests on run #11360 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Sync service provider > recovers from a dropped message |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
This was referenced Jul 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3618
Also only load core highlight JS package in EditorFactory.js (required for syntax highlighting in plaintext editing). This reduces the size for compiled editor.js by almost 1MB.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)