[stable25] fix(Viewer): remove outdated fix from stable16.#4121
Merged
juliusknorr merged 2 commits intostable25from May 4, 2023
Merged
[stable25] fix(Viewer): remove outdated fix from stable16.#4121juliusknorr merged 2 commits intostable25from
juliusknorr merged 2 commits intostable25from
Conversation
This broke the viewer resize and is not needed anymore. In order to confirm this is not needed i replaced the `beforeMount` handler with a `console.info` call opened a text in the viewer and resized the window a few times. The provided info only showed up once. So the `ViewerComponent` was only mounted once as well. Fixes #4099. Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
approved these changes
May 4, 2023
Collaborator
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Collaborator
|
confirmed locally that this does not lead to reloading of the viewer component. |
Passing run #9655 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #4117