fix: reconnect - reload main container #3627
Conversation
79ed6de to
8acd9c1
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
/backport a6913ea to stable25 |
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
8acd9c1 to
ef77280
Compare
juliusknorr
left a comment
There was a problem hiding this comment.
Great. Also good idea to pull out the moment updating.
|
For a cypress test we could probably intercept the create session request, store the session id and token and then manually issue a close session request in the test. |
ef77280 to
42dd0a6
Compare
* Use a computed to react on changes to document.lastSavedVersionTime. * Make the computed refresh every 20 seconds to dynamically update. Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Introduce `hasEditor` as reactive data to dynamically reload the MainContainer. $editor is not reactive. Once the MainContainer was rendered it stayed - even when the connection expired. The child components of MainContainer would still have the old $editor value. Fixes #3374. Signed-off-by: Max <[email protected]>
Move the event listener removal out of the close function and use it to disconnect when attempting to reconnect. Signed-off-by: Max <[email protected]>
42dd0a6 to
7360d1c
Compare
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
|
The backport to stable25 failed. Please do this backport manually. |
|
/backport 434f6e5,9b98212757b4af01534b73101eaba1c607bb1840,b7ec01b51fb9226086cde978ce35728aca022923,7360d1c8db69bab8c9ae64f104ec904249a0227d to stable25 |
|
The backport to stable25 failed. Please do this backport manually. |
|
The relevant parts have been backported to stable25 in #3635 thanks to @max-nextcloud |
📝 Summary
Introduce
hasEditoras reactive data to dynamically reload the MainContainer.$editoris not reactive.Once the
MainContainerwas rendered it stayed - even when$editorwas reset during reconnection.The child components of
MainContainerwould still use the old$editorvalue.This Pull request includes some refactoring and cleanup commits before and after the actual change.
Tests are not included as i could not think of a way to trigger the connection to expire.