Don't empty list of headings in onDestroy#3528
Merged
Conversation
Member
Author
|
/backport to stable25 |
f283e68 to
c403d06
Compare
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
juliusknorr
approved these changes
Dec 7, 2022
c403d06 to
8a4ac51
Compare
When switching pages in Collectives, `onDestroy` from the old editor instance happens *after* `onCreate` of the new editor instance. Since both share the same vuex store, this leads to a race condition where the old instance clears the list of headings of the new instance. Since we always set headings during `onCreate` anyway, there's no need to clear the headings in `onDestroy`, so let's simply get rid of it. Signed-off-by: Jonas <jonas@freesources.org>
8a4ac51 to
6135f89
Compare
Member
Author
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
|
The backport to stable25 failed. Please do this backport manually. |
Member
Author
|
/backport 6135f89 to stable25 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
When switching pages in Collectives,
onDestroyfrom the old editor instance happens afteronCreateof the new editor instance. Since both share the same vuex store, this leads to a race condition where the old instance clears the list of headings of the new instance.Since we always set headings during
onCreateanyway, there's no need to clear the headings inonDestroy, so let's simply get rid of it.Signed-off-by: Jonas jonas@freesources.org
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)