Fix hard line breaks displayed with additional new line between#3388
Fix hard line breaks displayed with additional new line between#3388juliusknorr merged 4 commits intomasterfrom
Conversation
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Failures
Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||||||||||
|
/compile |
|
Looks like the common mark specs expect a newline after a I wonder if we could still keep this and use some css or so to ignore / remove the extra blank line. |
|
Thanks again for the fix @susnux It would be great to have a test case for this case |
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
To preserve softbreaks within md files we preserve all whitespaces, so we must not introduce additional new lines after `<br>` elements. Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
No additional new line should be added after hard line breaks, this is tested by a new tiptap test. Modified CommonMark rendering test to allow hard breaks without newline. Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
|
@juliushaertl Added a test case for this. @max-nextcloud I first thought about adding a special "softbreak" node which would be rendered as a space, but that might add too much complexity. |
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
|
/backport to stable25 |
|
The backport to stable25 failed. Please do this backport manually. |
Summary
To preserve soft breaks within markdown files we preserve all whitespaces, so we must not introduce additional new lines after
<br>elements.