Fix: menubar throws errors on master focus trap too much recursion

[vinicius73]

• Resolves: MenuBar throws errors on master (focus-trap too much recursion) #2842
• Target version: master

Summary

• use menu bar as container for emoji, upload and list actions (solves Recursive calls of focusTrap() in NcActions component nextcloud-libraries/nextcloud-vue#3154)
• fix emoji picker
  • add regression tests

[vinicius73]

/compile

[susnux]

For me it works now almost perfectly, with two issues remaining:

1. The image sub-menu still throws the focus trap recursion error
2. If I open the formatting help the focus is "trapped" somewhere else (I can not click the X to close it).

[vinicius73]

2. If I open the formatting help the focus is "trapped" somewhere else (I can not click the X to close it).

I can't use the same solution in the modal 😢
Modals can't contain other modals.

[vinicius73]

/compile

[vinicius73]

/rebase

[susnux]

Thank you, the attachment sub-menu works perfectly now!
I am not sure if the formatting help issue is related, as it works, but the clickable area is limited to a small area (lower third)

@vinicius73 maybe you can also have a look at the table settings? As I get the same focus trap error when clicking on it and hover "delete this table".

[vinicius73]

@vinicius73 maybe you can also have a look at the table settings? As I get the same focus trap error when clicking on it and hover "delete this table".

Sure, thanks to report it.

[vinicius73]

/compile

[vinicius73]

/backport 17c2da2,ded2e2c496beabe568938b3423f8e58e36a1ddb5,e2b2dee6b063a9a1f253d9e348e2679a6915a7f0 to stable25