Skip to content

Use '(n)' suffix instead of timestamp prefix for uploaded image names#2376

Merged
julien-nc merged 2 commits intomasterfrom
enh/2338/image-name-no-timestamp
May 9, 2022
Merged

Use '(n)' suffix instead of timestamp prefix for uploaded image names#2376
julien-nc merged 2 commits intomasterfrom
enh/2338/image-name-no-timestamp

Conversation

@julien-nc
Copy link
Member

@julien-nc julien-nc commented May 9, 2022 •
edited
Loading

refs #2338

If foo.png is uploaded but already exists in the attachment folder, file is named foo (2).png. If uploaded again, foo (3).png. And so on.

@julien-nc julien-nc added this to the Nextcloud 25 milestone May 9, 2022
refs #2338 use '(n)' suffix instead of timestamp prefix to make sure …
6759366 
…attachment names are unique

Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
@julien-nc julien-nc force-pushed the enh/2338/image-name-no-timestamp branch from 24dc8de to 6759366 Compare May 9, 2022 10:46
@vinicius73
Copy link
Member

vinicius73 commented May 9, 2022

@eneiluj it's possible to create a test for it to prevent regressions?

mejo-
mejo- approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, works like a charm. Thanks a lot @eneiluj for looking into it 💜

One day we should add such a getUniqueFilename() function to Nextcloud itself - I already know of at least four independent implementations for that 🤪

@julien-nc
Copy link
Member Author

julien-nc commented May 9, 2022

@vinicius73 Yes I'll create a test, thanks for the suggestion.

refs #2338 improve and test ImageService::getUniqueFileName()
c0c2964 
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
@julien-nc julien-nc force-pushed the enh/2338/image-name-no-timestamp branch from 4047a08 to c0c2964 Compare May 9, 2022 16:22
@julien-nc julien-nc merged commit 1408efd into master May 9, 2022
@delete-merged-branch delete-merged-branch bot deleted the enh/2338/image-name-no-timestamp branch May 9, 2022 16:37
@mejo-
Copy link
Member

mejo- commented May 9, 2022

We probably should backport this to stable24, no?

@mejo-
Copy link
Member

mejo- commented May 9, 2022

/backport to stable24

@julien-nc
Copy link
Member Author

julien-nc commented May 9, 2022

@mejo- Yep!
And thanks for the review!

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 9, 2022
Merged
@susnux susnux mentioned this pull request Jun 17, 2022
Closed
@max-nextcloud max-nextcloud added the backported successfully backported label Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vinicius73 vinicius73 vinicius73 approved these changes

@mejo- mejo- mejo- approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

Assignees

No one assigned

Labels

3. to review backported successfully backported enhancement New feature or request feature: embed format: markdown

Projects

None yet

Milestone

Nextcloud 25

Development

Successfully merging this pull request may close these issues.

4 participants

@julien-nc @vinicius73 @mejo- @max-nextcloud