Skip to content

Add Cypress tests for image insertion#2060

Merged
juliusknorr merged 6 commits intomasterfrom
enh/cypress-image
Jan 10, 2022
Merged

Add Cypress tests for image insertion#2060
juliusknorr merged 6 commits intomasterfrom
enh/cypress-image

Conversation

@julien-nc
Copy link
Member

@julien-nc julien-nc commented Jan 7, 2022

refs #1900
fixes #2049
Tests:

  • Insert image from Files
  • Insert image from a link
  • Upload a local image

The logic is to:

  • Click on the menu action
  • Perform the specific extra actions to select a file or upload a file or provide a link
  • Intercept the network request to get the created file name
  • Check the image is visible in the editor

A command to delete users has been added. It makes it more convenient for those who are not using a temporary NC instance to run the tests 😁.

Julien Veyssier added 5 commits January 7, 2022 10:53
@julien-nc julien-nc added enhancement New feature or request tests If you write them we ♥ you 3. to review labels Jan 7, 2022
@julien-nc julien-nc added this to the Nextcloud 24 milestone Jan 7, 2022
@juliusknorr juliusknorr merged commit e8be435 into master Jan 10, 2022
@juliusknorr juliusknorr deleted the enh/cypress-image branch January 10, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@azul azul Awaiting requested review from azul

@mejo- mejo- Awaiting requested review from mejo-

Assignees

No one assigned

Labels

3. to review enhancement New feature or request tests If you write them we ♥ you

Projects

None yet

Milestone

Nextcloud 24

Development

Successfully merging this pull request may close these issues.

E2E tests for image insertion

2 participants

@julien-nc @juliusknorr