Conversation
Contributor
Author
|
see also #2021 |
mejo-
approved these changes
Dec 21, 2021
Contributor
Author
|
Also include a commit from stable22 that makes sure we actually use the specified node version. |
Contributor
Author
|
@juliushaertl I am not entirely sure if including the change to build the viewer in testing mode should be backported. I used the original commit because i felt it would increase consistency accross branches. |
Contributor
Author
Okay... it's causing the build to fail... So i guess i will just make sure we use the propper node version and remain consistent with what we had with stable21. |
On CI we want to test this with the stable21 branch of the server. Also make sure to use the specified node version. For running local the server image will use the BRANCH environment variable to determine which branch of the server to checkout: https://github.com/nextcloud/docker-ci/blob/master/server/initnc.sh#L3-L12 Signed-off-by: Azul <azul@riseup.net>
This was referenced Jan 7, 2022
This was referenced Jan 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The server image will use the BRANCH environment variable
to determine which branch of the server to checkout:
https://github.com/nextcloud/docker-ci/blob/master/server/initnc.sh#L3-L12
So we were effectively using the latest master which led to test failures as it has a rewritten API for injecting app scripts.