fix design when keyboard is shown by mahibi · Pull Request #1285 · nextcloud/talk-android

mahibi · 2021-05-22T00:23:17Z

fix #992
might also be a fix for #1029

basically with this PR issue #992 is fixed by setting windowSoftInputMode to adjustResize and deleting the KeyboardUtils.
This in turn caused conflicts with https://github.com/Kennyc1012/BottomSheetMenu which was now replaced with androids BottomSheetDialog
The replacing of the bottom dialog lib led to quite some refactoring.

For now, while using the BottomSheetDialog there are some workarounds (=add more routers) to keep using the controllers from conductor.

fixed design in conversation	conversation bottom dialog	input dialog moved over keyboard

Signed-off-by: Marcel Hibbe dev@mhibbe.de

mahibi · 2021-11-02T19:32:37Z

deleting the KeyboardUtils will lead to a bug that the BottomSheet (https://github.com/Kennyc1012/BottomSheetMenu) is hidden under the keyboard (for example when entering a name for a new group).

I guess the best solution is to get rid of the BottomSheet lib. It even doesn't support customized views any more in newer versions, see https://github.com/Kennyc1012/BottomSheetMenu#upgrading-to-3x
The bug with the keyboard hiding the BottomSheet was known (see Kennyc1012/BottomSheetMenu#55) but there was never a solution by this lib, so that's where the KeyboardUtils made sense i guess.

So we should try to replace this lib with other solutions like android's BottomSheetDialogFragment
( https://developer.android.com/reference/com/google/android/material/bottomsheet/BottomSheetDialogFragment )

I remember we had the idea to unify the "creation of groups" between iOS and android at the hackweek meeting @nickvergessen
So if there are anyway any other ideas instead to have a menu at the bottom it might be a win win to also get rid of the bug that the Actionbar is partially hidden whenever keyboard is shown..

actionbarVisibleButBottomSheetHidden.mp4

AndyScherzinger · 2022-02-14T07:59:50Z

@mahibi looking good, I did add some color improvements over the weekend for the bottom sheets for dark/light theming and improved the detekt/ktlint scores. Hope it helps. 💙

mahibi · 2022-02-14T09:40:04Z

@mahibi looking good, I did add some color improvements over the weekend for the bottom sheets for dark/light theming and improved the detekt/ktlint scores. Hope it helps. blue_heart

cool, thanks @AndyScherzinger 👍

app/src/main/java/com/nextcloud/talk/controllers/ConversationsListController.java

AndyScherzinger · 2022-02-15T09:31:57Z

@mahibi fixed detekt and 2 lint issues

AndyScherzinger · 2022-02-15T16:45:31Z

@mahibi looks good, one thing though (at least on Android 12 on my OP9Pro): i.e. when marking a conversation as a favorite, after the "success animation" the bottom sheet isn't closed automatically anymore. This has been working before, so maybe that part didn't get migrated?

app/src/main/java/com/nextcloud/talk/controllers/bottomsheet/EntryMenuController.java

mahibi · 2022-02-15T17:39:11Z

@mahibi looks good, one thing though (at least on Android 12 on my OP9Pro): i.e. when marking a conversation as a favorite, after the "success animation" the bottom sheet isn't closed automatically anymore. This has been working before, so maybe that part didn't get migrated?

indeed that was not migrated! fixed now

AndyScherzinger

@mahibi works like a charm, just needs a single ktlint fix 👍

mahibi · 2022-02-16T09:44:36Z

@mahibi works like a charm, just needs a single ktlint fix +1

@AndyScherzinger well the klint warning is exactly about the wildcard import suggested by @timkrueger
#1285 (comment)

So should we

avoid wildcard imports?
change klint config to allow them?
import every single enum as static?
type ConversationOperationEnum.OPS_.... every time inside the code?
yolo and merge? :D

timkrueger · 2022-02-16T10:18:16Z

import every single enum as static?

I would prefer to import every single enum value as static.