Skip to content

Use a newer version of the nextcloudci/php7.1 Docker image in Drone#403

Merged
nickvergessen merged 1 commit intomasterfrom
use-newer-version-of-php7.1-image-in-drone
Sep 14, 2017
Merged

Use a newer version of the nextcloudci/php7.1 Docker image in Drone#403
nickvergessen merged 1 commit intomasterfrom
use-newer-version-of-php7.1-image-in-drone

Conversation

@danxuliu
Copy link
Member

The php7.1 and php7.1-integration tests seem to be running in Drone, but in fact they are not; although there are no errors, if you take a closer look to their output you can see that the tests themselves are not run either (see, for example, php7.1 log for pull request 100 and php7.1-integration log for pull request 100.

As the spreed repository only contains the app, in order to run the tests Drone downloads and executes https://github.com/nextcloud/travis_ci/master/before_install.sh, which downloads the server and prepares the environment as needed, and then downloads and executes https://github.com/nextcloud/travis_ci/master/core_install.sh, which installs the Nextcloud server as needed depending on the desired database to be used for the test.

The problem comes from the more ./tests/autoconfig-oracle.php command in core_install.sh (introduced in commit Try fixing OCI from pull request Allow apps to test on oracle, although I do not understand the rationale of that command there; @nickvergessen, any insights?); for some strange reason, when executed without a TTY on a CentOS based Docker image it breaks the execution of the remaining Drone commands (which include running the tests), although no error is issued and thus the tests wrongly seem to have been successfully run in the general Drone view.

When executed on a Debian based image, though, everything works as expected; I was not able to determine why it fails in the CentOS image (more belongs to the util-linux package; the source code for the release 2.23.2 of util-linux, which is the one used in the nextcloudci/php7.1:php7.1-3 image, can be found here if you want to investigate ;-) ), but simply using a newer nextcloudci/php7.1 image based on Debian is enough to make the tests work in Drone, and also removes the need of installing wget each time the tests are run as it is already included in the image.

The "php7.1" and "php7.1-integration" tests are not actually being run
in Drone; when the command "more ./tests/autoconfig-oracle.php" is
executed by "core_install.sh" the execution of the remaining Drone
commands is broken (strange... probably some black magic related to TTYs
or something like that), and thus the tests are not run (although no
error is issued, so it wrongly seems that they were successful).

The problem occurs on CentOS based Docker images, but not on Debian
based ones. Therefore, the base images for the "php7.1" and
"php7.1-integration" tests were changed to use a newer version of the
"nextcloudci/php7.1" image, which is now based on Debian instead of
CentOS like the older ones.

This also removes the need of installing "wget", as it is already
included in the newer image too.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@codecov
Copy link

codecov bot commented Sep 14, 2017

Codecov Report

Merging #403 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #403   +/-   ##
=========================================
  Coverage     12.28%   12.28%           
  Complexity      343      343           
=========================================
  Files            22       22           
  Lines          1644     1644           
=========================================
  Hits            202      202           
  Misses         1442     1442

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ed8e7f...b53198f. Read the comment docs.

@nickvergessen nickvergessen merged commit d7adb45 into master Sep 14, 2017
@nickvergessen nickvergessen deleted the use-newer-version-of-php7.1-image-in-drone branch September 14, 2017 12:53
marcoambrosini pushed a commit that referenced this pull request Oct 9, 2019
Display Multiselect white spaces on first part too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants