test: Check if someone broke file sharing with Talk#15726
Merged
nickvergessen merged 1 commit intomainfrom Aug 27, 2025
Merged
Conversation
90eda64 to
d641d17
Compare
miaulalala
approved these changes
Aug 27, 2025
…till shared Signed-off-by: Joas Schilling <coding@schilljs.com>
d641d17 to
3d04a58
Compare
Member
Author
|
Member
Author
|
/backport to stable31 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Talk integration tests started failing
I bisected:
nextcloud/server#54197
I logged the accesslist here:
spreed/lib/Files/Util.php
Lines 39 to 62 in 956a1ab
It seems it returns the user even though the share was deleted:
If I add a PROPFIND from particiapnt2 before getting the room it fails the request correctly with 404 as it is no longer shared with anyone:
90eda64
I assume correct that this is intended right?
It's basically a proof that the caching is working. Unfortunately this also means that you'd receive activity and other things until your filesystem was setup again?
🏁 Checklist
docs/has been updated or is not required