Always notify in one2one rooms

[nickvergessen]

• Based on Start with system chat messages #1067

Notification is only send, when you don't have an active session for the room.
Or should we still do this, so you beep-boop when you have the tab open somewhere in the background? @mario @jancborchardt

Fix #875

[mario]

Few things conceptually before I look into the code:

a) We should probably kill mentions and just send general chat message, but up to you (e.g. if user is mentioned, do we only send mention and not a general chat message to THAT user?)

Based on your code, it seems we keep MENTIONS only for group/public chats, and always notify on one-to-one chats. Let me know if I'm wrong.

b) We should ALWAYS send notifications and the client should decide when to show it

My idea is the following:
- you receive a push notification for chat

• are there already notifications for that chat?
  • YES - Show "There are more pending messages" notification
  • NO - Show the message in a notification

c) Is there a reason we do this only for one2one conversations?

[nickvergessen]

Is there a reason we do this only for one2one conversations?

Yes, imagine your phone ringing 500 times during a company call.

[mario]

@nickvergessen for chat notifications? If you're in a call, all notifications would play NO sound, of course.

[nickvergessen]

Yeah well, but does your phone know you are active on the desktop or vice versa?

[mario]

No (well, partly only). Unfortunately that's an issue, but not a huge one.

[GoetheG]

Let the user decide.

[mario]

@GoetheG this is not how it should work.

[jancborchardt]

@nickvergessen yes, notification should also be sent when tab is open in background. But of course only for 1on1 calls or mentions to you in groups.

[nickvergessen]

Rebased on #1067 to resolve conflicts

[mario]

So will this be changed for every type of room? :)

[nickvergessen]

See PR title for details

[mario]

@nickvergessen we should definitely still do it when in the background.

But I want this to work in the group/public calls too.

[nickvergessen]

Which we cant do with the current iOS notifications because it can't silence them... Step by step inti the right direction

[nickvergessen]

@Ivansss ready to review