[stable23] Fix FreeBsd Interface parsing#375
Conversation
|
Ok, it ate the changes to lib/OperatingSystems/FreeBSD.php no clue how to fix that :) |
check out this branch and commit and push fixes to it. |
|
I have no write permission here so that's a bit difficult.... |
Ah! Okay, you've been invited :) |
|
/rebase |
|
Yeah not sure how to best get it to do that check.... Github is weird that way.... |
Can you rebase your branch to stable23? This should get the latest changes in and hopefully trigger a CI re run. |
|
@kesselb I mean I can, but it's not really my branch anyways since the backport bot opened it so who ever wants to do it, it's fine by me :) |
|
Alas it'd be neat if someone did it, I rarely rebase stuff and before I break something I'd rather someone else do it |
…d or mac Signed-off-by: Kai Dederichs <kai.dederichs@protonmail.com> Make test throw when requesting a non-valid interface Signed-off-by: Kai Dederichs <kai.dederichs@protonmail.com> Backport FreeBSD.php to stable23 Signed-off-by: Kai Dederichs <k.dederichs@spicymedia.io> Fix CS Signed-off-by: Kai Dederichs <k.dederichs@spicymedia.io>
46353b8 to
fb73c95
Compare
|
@KDederichs done. All changes are there? ;) |
|
Looking good yeah, but I guess that one is still not running? Or does it depend on the PHPUnit one? |
backport of #372