[stable12] Show EOL warning in the update section#8987
Merged
Conversation
MorrisJobke
reviewed
Apr 12, 2018
|
|
||
| $params = [ | ||
| 'isNewVersionAvailable' => !empty($updateState['updateAvailable']), | ||
| 'isNewVersionAvailable' => true, //!empty($updateState['updateAvailable']), |
6737553 to
30626ed
Compare
Codecov Report
@@ Coverage Diff @@
## stable12 #8987 +/- ##
==============================================
- Coverage 53.91% 53.91% -0.01%
- Complexity 22780 22782 +2
==============================================
Files 1387 1387
Lines 87286 87295 +9
Branches 1331 1331
==============================================
+ Hits 47063 47065 +2
- Misses 40223 40230 +7
|
MorrisJobke
approved these changes
Apr 12, 2018
Member
MorrisJobke
left a comment
There was a problem hiding this comment.
Rebased and fixed the typo. And works 👍
Signed-off-by: Joas Schilling <coding@schilljs.com>
30626ed to
5f1f633
Compare
Member
Author
|
Rebased and fixed the last failing test |
rullzer
approved these changes
Apr 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #8986