the FN is optional, carrying the displayname if present#8822
Merged
Conversation
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Codecov Report
@@ Coverage Diff @@
## master #8822 +/- ##
============================================
+ Coverage 51.89% 51.89% +<.01%
- Complexity 25267 25269 +2
============================================
Files 1605 1605
Lines 94771 94775 +4
Branches 1377 1377
============================================
+ Hits 49180 49187 +7
+ Misses 45591 45588 -3
|
nickvergessen
approved these changes
Mar 14, 2018
Member
Author
|
tested successfully (#8641 (comment)) taking as +1 → merging |
Member
Author
|
backported to 13 only, patch does not apply to 12. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #8641
fixes a warning that is logged if the field is not present