Conversation
* Always show delete icon * Hide form if the new icon is deleted
|
@rullzer, thanks for your PR! By analyzing the annotation information on this pull request, we identified @ChristophWurst, @jancborchardt and @icewind1991 to be potential reviewers |
| <span><?php p($l->t('Use the credentials below to configure your app or device.')); ?></span> | ||
| <span> | ||
| <?php p($l->t('Use the credentials below to configure your app or device.')); ?> | ||
| <?php p($l->t('For security reasons this password will only be shown once.')); ?> |
Member
There was a problem hiding this comment.
A general questions: do we backport translations too? E.g. this string was probably not in NC10 before, hence it won't be translated properly
Member
There was a problem hiding this comment.
A general questions: do we backport translations too? E.g. this string was probably not in NC10 before, hence it won't be translated properly
I plan to fix this behavior soon ;)
Member
|
Tested and works 👍 |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #806
For #735
CC: @MorrisJobke @LukasReschke