Show warning if slash is entered as filename#7676
Merged
Conversation
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Member
|
For now, fine 😉 But what do you think about creating a directory with that file when somebody types in "testfolder/testdoc.docx" as document name 🤔 @MorrisJobke |
Member
Author
Something for later and also a bit over the top from my point of view. |
* hides log entries for the case the parent folder does not exist Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Codecov Report
@@ Coverage Diff @@
## master #7676 +/- ##
===========================================
+ Coverage 51.19% 51.2% +0.01%
- Complexity 24888 24893 +5
===========================================
Files 1601 1602 +1
Lines 94781 94803 +22
Branches 1371 1372 +1
===========================================
+ Hits 48523 48544 +21
- Misses 46258 46259 +1
|
Member
Author
|
The second commit fixes all the cases of #6594 (comment) and logs them as debug logs. |
This was referenced Jan 3, 2018
Merged
blizzz
approved these changes
Jan 3, 2018
skjnldsv
approved these changes
Jan 3, 2018
Member
skjnldsv
left a comment
There was a problem hiding this comment.
Strange it was not already implemented! 🤔
rullzer
approved these changes
Jan 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6594 when creating or renaming a file.