Merged
Conversation
skjnldsv
approved these changes
Jan 3, 2018
Codecov Report
@@ Coverage Diff @@
## master #7669 +/- ##
============================================
- Coverage 51.2% 51.19% -0.01%
- Complexity 24893 24894 +1
============================================
Files 1602 1602
Lines 94804 94813 +9
Branches 1372 1373 +1
============================================
Hits 48543 48543
- Misses 46261 46270 +9
|
Member
|
@juliushaertl is it possible to backport this to stable12? |
Member
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2dfced7 to
63b4d7e
Compare
Member
Author
|
@MorrisJobke Fixed for edge as well. 😉 |
Member
Member
Author
|
@MorrisJobke That's quite strange. Works fine here with Edge and IE11 |
Member
Let me retest this then :) |
MorrisJobke
approved these changes
Jan 3, 2018
Member
MorrisJobke
left a comment
There was a problem hiding this comment.
Tested and works now ... I guess it was a caching issue, because I rolled back and forward a lot on this instance. With a fresh install it worked fine. 👍
Member
|
@juliushaertl Could we backport this to stable12? |
Member
Author
|
I see no problem there, let me have a look. |
Member
Author
|
backported at #7684 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes #7408
This PR also includes some minor fixes to the apps management on IE11.
Before:

After:

Tested with Chrome, Firefox and IE11
@nextcloud/designers