Don't spam the log when we could not properly connect to the appstore#7646
Merged
Don't spam the log when we could not properly connect to the appstore#7646
Conversation
If we can't connect to the appstore for some reason we don't have to log the exception just an info entry is enough. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
blizzz
approved these changes
Dec 29, 2017
MorrisJobke
reviewed
Jan 2, 2018
| return json_decode($file->getContent(), true)['data']; | ||
| } catch (ConnectException $e) { | ||
| $this->logger->logException($e, ['app' => 'appstoreFetcher']); | ||
| $this->logger->info('Could not connect to appstore', ['app' => 'appstoreFetcher']); |
Member
There was a problem hiding this comment.
@rullzer You could also log the exception with an additional error message and a different log level (just specify message and level in the context parameter 😉 )
This was referenced Jan 2, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we can't connect to the appstore for some reason we don't have to log
the exception just an info entry is enough.
Avoids spamming the logs. And avoid spamming sentry.