Spelling: No ...., upgrades and email.#7583
Merged
MorrisJobke merged 2 commits intomasterfrom Jan 2, 2018
Merged
Conversation
MorrisJobke
reviewed
Dec 20, 2017
Member
MorrisJobke
left a comment
There was a problem hiding this comment.
Looks good, beside my inline comment
settings/js/apps.js
Outdated
| if (!_.isUndefined(app.author['@attributes']['mail'])) { | ||
| authors.push(app.author['@attributes']['mail']); | ||
| if (!_.isUndefined(app.author['@attributes']['email'])) { | ||
| authors.push(app.author['@attributes']['email']); |
Member
There was a problem hiding this comment.
This is wrong - it is mail: https://github.com/Stibila/defaultgroup/blob/514ac68f9b5c09b3ddf037285664807b21d3629d/appinfo/info.xml#L9
6ae6c39 to
e908722
Compare
Codecov Report
@@ Coverage Diff @@
## master #7583 +/- ##
============================================
- Coverage 29.15% 28.02% -1.14%
Complexity 23574 23574
============================================
Files 1445 1445
Lines 78871 82252 +3381
============================================
+ Hits 22996 23051 +55
- Misses 55875 59201 +3326
|
rullzer
approved these changes
Dec 29, 2017
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
e908722 to
f801dc8
Compare
MorrisJobke
approved these changes
Jan 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.