Conversation
Codecov Report
|
|
Good stuff, but why reduce it from 10px which we used basically everywhere to 3px? It looks a bit strange and more like a thick border than a slight shadow. |
Because we use that in our newer filters ;) See the line I just changed, I thought that we move to that. Otherwise we need to touch a lot more occurrences. |
|
I disagree! The filter: drop-shadow is far better than the box-shadow as the arrow isn't included in the shadow generation. I'm against the removal of this. What's up with safari anyway? it should supports filter? https://caniuse.com/#feat=css-filters 😕 |
|
Usually it does this, but somehow not for the notifications drop down. I will check tomorrow and adapt this pr then |
ed4ada2 to
818fed6
Compare
|
Okay - I moved to the 10px and to the |
* unify shadow blur from 3px to 10px * remove opacity of background of app labels * for IE: use box-shadow as fallback (because the filter: drop-shadow is not supported) Signed-off-by: Morris Jobke <hey@morrisjobke.de>
818fed6 to
f854831
Compare
Found while reviewing nextcloud/notifications#89
cc @nextcloud/designers
Before (opacity,
bigger blur, no shadow on notifications in Safari):After: