Skip to content

Reduce length of md5 in scss caching#7504

Merged
MorrisJobke merged 3 commits intomasterfrom
shorter-css-prefixes
Dec 14, 2017
Merged

Reduce length of md5 in scss caching#7504
MorrisJobke merged 3 commits intomasterfrom
shorter-css-prefixes

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Dec 14, 2017

Easier to debug.

Before After
kazam_screenshot_00011 kazam_screenshot_00010

@skjnldsv skjnldsv added 3. to review Waiting for reviews feature: scss labels Dec 14, 2017
@skjnldsv skjnldsv added this to the Nextcloud 13 milestone Dec 14, 2017
@skjnldsv skjnldsv self-assigned this Dec 14, 2017
rullzer
rullzer approved these changes Dec 14, 2017
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine by me

@MorrisJobke
Copy link
Member

MorrisJobke commented Dec 14, 2017

Unit test failures.

@skjnldsv
Reduce length of md5 in scss caching
f2d5927 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the shorter-css-prefixes branch from 9b43461 to f2d5927 Compare December 14, 2017 10:12
@codecov
Copy link

codecov bot commented Dec 14, 2017 •
edited
Loading

Codecov Report

Merging #7504 into master will decrease coverage by 16.39%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #7504      +/-   ##
============================================
- Coverage     51.16%   34.77%   -16.4%     
  Complexity    24865    24865              
============================================
  Files          1601     1601              
  Lines         94683    94683              
  Branches       1368     1368              
============================================
- Hits          48446    32923   -15523     
- Misses        46237    61760   +15523
Impacted Files Coverage Δ Complexity Δ
lib/private/Template/SCSSCacher.php 6.34% <0%> (-63.5%) 36 <0> (ø)
lib/private/Files/ObjectStore/Mapper.php 0% <0%> (-100%) 2% <0%> (ø)
lib/private/App/AppStore/Bundles/Bundle.php 0% <0%> (-100%) 2% <0%> (ø)
...ddleware/Security/Exceptions/NotAdminException.php 0% <0%> (-100%) 1% <0%> (ø)
...Check/Iterator/ExcludeFileByNameFilterIterator.php 0% <0%> (-100%) 2% <0%> (ø)
apps/files_trashbin/appinfo/app.php 0% <0%> (-100%) 0% <0%> (ø)
apps/dav/lib/CalDAV/Activity/Filter/Calendar.php 0% <0%> (-100%) 7% <0%> (ø)
lib/private/App/CodeChecker/EmptyCheck.php 0% <0%> (-100%) 6% <0%> (ø)
lib/public/AppFramework/Http/DownloadResponse.php 0% <0%> (-100%) 1% <0%> (ø)
apps/user_ldap/lib/Settings/Section.php 0% <0%> (-100%) 5% <0%> (ø)
... and 515 more

@skjnldsv
Test fixes
158f442 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Test fixes 2
b8778b0 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Copy link
Member Author

skjnldsv commented Dec 14, 2017

Test failure is unrelated, merging.

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 14, 2017
@MorrisJobke MorrisJobke merged commit b19b137 into master Dec 14, 2017
@MorrisJobke MorrisJobke deleted the shorter-css-prefixes branch December 14, 2017 11:12
@MorrisJobke MorrisJobke mentioned this pull request Jan 2, 2018
Merged
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@LukasReschke LukasReschke Awaiting requested review from LukasReschke

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@skjnldsv skjnldsv

Labels

4. to release Ready to be released and/or waiting for tests to finish feature: scss

Projects

None yet

Milestone

Nextcloud 13

Development

Successfully merging this pull request may close these issues.

3 participants

@skjnldsv @MorrisJobke @rullzer