Skip to content

Fix error log on PHP 7.2#7466

Merged
MorrisJobke merged 1 commit intomasterfrom
fix-php7.2-session-init
Dec 12, 2017
Merged

Fix error log on PHP 7.2#7466
MorrisJobke merged 1 commit intomasterfrom
fix-php7.2-session-init

Conversation

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Dec 12, 2017

Fixes following error in the logs: ini_set(): A session is active. You cannot change the session module's ini settings at this time

Basically moves the ini_set 5 lines to the top into the method call.

Found while testing the 13.0.0 beta 2 on PHP 7.2

Fixes following error in the logs: "ini_set(): A session is active. You cannot change the session module's ini settings at this time"

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 12, 2017
@MorrisJobke MorrisJobke merged commit 2943b54 into master Dec 12, 2017
@MorrisJobke MorrisJobke deleted the fix-php7.2-session-init branch December 12, 2017 14:45
@MorrisJobke MorrisJobke mentioned this pull request Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants