use fopen directly when reading objects from s3#6975
Merged
nickvergessen merged 1 commit intomasterfrom Nov 1, 2017
Merged
Conversation
MorrisJobke
approved these changes
Oct 27, 2017
Member
MorrisJobke
left a comment
There was a problem hiding this comment.
Tested and at least works with the existing files I have in my test environment.
MorrisJobke
reviewed
Oct 27, 2017
| /** @var StreamInterface $body */ | ||
| $body = $result['Body']; | ||
| $request = \Aws\serialize($command); | ||
| $opts = array( |
Member
There was a problem hiding this comment.
Could you use [] instead of array()
Signed-off-by: Robin Appelman <robin@icewind.nl>
2edb148 to
f9a7294
Compare
Codecov Report
@@ Coverage Diff @@
## master #6975 +/- ##
============================================
- Coverage 52.82% 52.82% -0.01%
Complexity 22802 22802
============================================
Files 1442 1442
Lines 88562 88565 +3
Branches 1349 1349
============================================
- Hits 46787 46783 -4
- Misses 41775 41782 +7
|
Member
|
Does a backport make sense here? |
Member
|
@MorrisJobke yes, we need to backort it, please review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bypassing curl/guzzle.
This might help with errors when dealing with large downloads