Conversation
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
| <div id="uploadprogresswrapper"> | ||
| <div id="uploadprogressbar"> | ||
| <em class="label outer" style="display:none"><span class="desktop"><?php p($l->t('Uploading @'));?></span><span class="mobile"><?php p($l->t('…'));?></span></em> | ||
| <em class="label outer" style="display:none"><span class="desktop"><?php p($l->t('Uploading…'));?></span><span class="mobile"><?php p($l->t('…'));?></span></em> |
There was a problem hiding this comment.
At least in Mail, @jancborchardt always tells me that there should be a space between the last word and the …. In case this applies here too, we should have it consistent like Uploading …
There was a problem hiding this comment.
Some of the translators at Transifex changed hundreds of occurences the last year.
@comradekingu Do you have a link or explanation at hand to prove our changes?
There was a problem hiding this comment.
@rakekniven @ChristophWurst
"Word …" is the official convention, for single action words in infinite form. Actual use is both ways. As long as it isn't tripledot, it isn't erroneous in English.
What I don't understand is why " @" is replaced by "…", outside of the spacing issue.
There was a problem hiding this comment.
The @ was the typo that should be fixed by this here. I will fix the spacing in a followup PR, okay?
Codecov Report
@@ Coverage Diff @@
## master #6936 +/- ##
============================================
- Coverage 52.84% 52.77% -0.07%
- Complexity 22806 22840 +34
============================================
Files 1441 1441
Lines 88557 88673 +116
Branches 1349 1349
============================================
Hits 46798 46798
- Misses 41759 41875 +116
|
rakekniven
left a comment
There was a problem hiding this comment.
Common grammar at Nextcloud
| <div id="uploadprogresswrapper"> | ||
| <div id="uploadprogressbar"> | ||
| <em class="label outer" style="display:none"><span class="desktop"><?php p($l->t('Uploading @'));?></span><span class="mobile"><?php p($l->t('…'));?></span></em> | ||
| <em class="label outer" style="display:none"><span class="desktop"><?php p($l->t('Uploading…'));?></span><span class="mobile"><?php p($l->t('…'));?></span></em> |
There was a problem hiding this comment.
Some of the translators at Transifex changed hundreds of occurences the last year.
@comradekingu Do you have a link or explanation at hand to prove our changes?
|
Yeah, there should always be a space before the ellipsis like "Uploading …" Ellipsis without space is only used when a word itself is ellipsized like "Someth…" |
Fix a typo noticed during backport of #6935