Conversation
IE11 triggers an 'input' event whenever an input is focussed or loses focus. Thus this causes an endless loading loop as soon as the view is re-rendered. To prevent this, this remembers the previous search term and ignores events where the term has not changed. Fixes #5281 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Codecov Report
@@ Coverage Diff @@
## master #6795 +/- ##
============================================
- Coverage 52.99% 52.99% -0.01%
Complexity 22657 22657
============================================
Files 1430 1430
Lines 88070 88073 +3
Branches 1343 1344 +1
============================================
- Hits 46677 46675 -2
- Misses 41393 41398 +5
|
Member
|
Nice stuff! |
rullzer
approved these changes
Oct 10, 2017
blizzz
approved these changes
Oct 12, 2017
Member
blizzz
left a comment
There was a problem hiding this comment.
no IE at hand, code looks good
Member
|
@ChristophWurst you do the backporting? |
Member
Author
Sure: #6823 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IE11 triggers an 'input' event whenever an input is focussed
or loses focus. Thus this causes an endless loading loop as soon
as the view is re-rendered. To prevent this, this remembers the
previous search term and ignores events where the term has not
changed.
Fixes #5281
Tested with IE11 on Win10 and FF58 (nightly) on Linux.