Add variable for border-radius and box-shadow

[jancborchardt]

As mentioned in #6649

Already using the values for filter instead of box-shadow as used in #6669 – instead of the old box-shadow: 0 1px 10px $color-box-shadow;

[skjnldsv]

Don't you want to replace all the occurrences with the variable in this pr too? :)

[codecov]

Codecov Report

Merging #6688 into master will increase coverage by 2.41%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #6688      +/-   ##
============================================
+ Coverage     50.61%   53.03%   +2.41%     
+ Complexity    24297    22583    -1714     
============================================
  Files          1577     1417     -160     
  Lines         92922    87866    -5056     
  Branches       1359     1341      -18     
============================================
- Hits          47036    46601     -435     
+ Misses        45886    41265    -4621

Impacted Files	Coverage Δ	Complexity Δ
...es_sharing/lib/Controller/ShareesAPIController.php	64.47% <0%> (-5.53%)	114% <0%> (+90%)
apps/comments/js/commentcollection.js	86.36% <0%> (-4.55%)	0% <0%> (ø)
lib/private/Memcache/Factory.php	70.83% <0%> (-4.17%)	21% <0%> (ø)
settings/Controller/AppSettingsController.php	16.15% <0%> (-3.05%)	65% <0%> (-6%)
apps/dav/lib/CalDAV/CalendarObject.php	88.57% <0%> (-2.13%)	19% <0%> (-1%)
apps/user_ldap/lib/User_LDAP.php	72.65% <0%> (-1.53%)	73% <0%> (ø)
apps/user_ldap/lib/Proxy.php	50% <0%> (-1.48%)	21% <0%> (+2%)
lib/private/Installer.php	50.17% <0%> (-1.04%)	75% <0%> (ø)
core/js/share.js	40.98% <0%> (-0.96%)	0% <0%> (ø)
apps/files_sharing/js/public.js	47.91% <0%> (-0.83%)	0% <0%> (ø)
... and 249 more

[skjnldsv]

Where are we at here? :)

[jancborchardt]

Done and ready for review! :)

• I replaced all occurences of border-radius: 3px; in the files which are already scss. I would prefer to do the moving of other files to SCSS separately.
• I removed the popover-shadow variable again because it actually only had a single occurence, it’s very specific, and we already have the $color-box-shadow.

Let’s get this in, please review @nextcloud/designers – it’s just the border-radius standardization to 3px now. :)

[skjnldsv]

Perfect!

[skjnldsv]

I always approve when I see the word "standardization"! :)

[jancborchardt]

Drone is irrelevant since this is CSS only → merging :)