Skip to content

Move invite-accepted capability and implementation to contacts app.#57853

Open
redblom wants to merge 4 commits intonextcloud:masterfrom
redblom:move-ocm-invite-accepted-route-impl-to-contacts-app
Open

Move invite-accepted capability and implementation to contacts app.#57853
redblom wants to merge 4 commits intonextcloud:masterfrom
redblom:move-ocm-invite-accepted-route-impl-to-contacts-app

Conversation

@redblom
Copy link

@redblom redblom commented Jan 27, 2026

  • Resolves: #

Summary

Code moved to contacts app, see nextcloud/contacts#4417

TODO

  • deal with inviteAcceptedDialog code

Checklist

@redblom redblom requested a review from a team as a code owner January 27, 2026 15:43
@redblom redblom requested review from leftybournes, nfebe, salmart-dev and sorbaugh and removed request for a team January 27, 2026 15:43
@redblom redblom marked this pull request as draft January 27, 2026 15:43
@ChristophWurst
Copy link
Member

@redblom why is this moved out of server and could it break OCM when the contacts app is not installed? the app is not shipped. it is optional.

@redblom redblom force-pushed the move-ocm-invite-accepted-route-impl-to-contacts-app branch from 7cb53f3 to 2d2e4a1 Compare January 28, 2026 16:58
@ArtificialOwl
Copy link
Member

@redblom why is this moved out of server and could it break OCM when the contacts app is not installed? the app is not shipped. it is optional.

This is done on my request:

  • it is moved out of server because the implementation of the feature creates its own db table and does not provide an API to manage it,
  • it will not break OCM, it will only not enable the 'invite-accepted' capability if contacts is not installed. the capability is useless without the contacts app,
  • contacts will register the capability and fully manage the db table

@ArtificialOwl
Copy link
Member

let's ping @mickenordin on this one !

@mickenordin mickenordin force-pushed the move-ocm-invite-accepted-route-impl-to-contacts-app branch from 2d2e4a1 to aea3c70 Compare January 28, 2026 18:22
@mickenordin
Copy link
Contributor

let's ping @mickenordin on this one !

I haven't reviewed the change, but in principal I see no problem with it.

@redblom redblom force-pushed the move-ocm-invite-accepted-route-impl-to-contacts-app branch from aea3c70 to 254681c Compare January 30, 2026 09:26
@redblom
Copy link
Author

redblom commented Jan 30, 2026

Rebased, squashed, removed draft label.

@redblom redblom marked this pull request as ready for review January 30, 2026 10:12
@redblom redblom requested review from a team and nickvergessen as code owners January 30, 2026 10:12
@redblom redblom force-pushed the move-ocm-invite-accepted-route-impl-to-contacts-app branch from f6d739f to 3948b49 Compare February 3, 2026 09:49
…cts app.

Signed-off-by: antoonp <antoon@redblom.com>
Signed-off-by: antoonp <antoon@redblom.com>
Signed-off-by: antoonp <antoon@redblom.com>
Signed-off-by: antoonp <antoon@redblom.com>
@redblom redblom force-pushed the move-ocm-invite-accepted-route-impl-to-contacts-app branch from 3948b49 to 57769de Compare February 4, 2026 09:30
@redblom redblom requested a review from nickvergessen February 4, 2026 09:33
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@miaulalala
Copy link
Contributor

miaulalala commented Feb 11, 2026

Hey @redblom , can you do the following things?

  • Fetch current master - git fetch origin (if your remote is not called origin, replace it with whatever your remote name is)
  • Squash your commits into a single one, and add a signoff
    • The easiest way is using git reset --soft origin/master - this will reset your branch to master but leave all your changes as staged files so nothing is lost. It removes your commit history, but not your file changes.
  • Run composer cs:fix to autofix the PHP linting issues
  • Then you can do your usual git add (I like using git add -p to check my changes in chunks within a diff view, but you do you 😉 ) to stage your lint fixes
  • Use `git commit -sm "fix: your message here" to signoff your commit
  • push to your branch
  • Ping me and I'll enable the workflows

ETA: you can do the same workflow on the contacts branch too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants