refactor(IShare): Add typing for IShare#57575
Merged
provokateurin merged 1 commit intomasterfrom Jan 27, 2026
Merged
Conversation
c63846f to
7ae0c6f
Compare
7ae0c6f to
c9ff2e8
Compare
Merged
Altahrim
approved these changes
Jan 16, 2026
8b6715c to
cec0a3b
Compare
Member
Author
Yeah feels tiny to risky to do that in 33. Not worth the tiny performance improvements |
cec0a3b to
c1575e9
Compare
Member
Author
|
Converting to draft until we do a branching as this is NC 34 only material |
provokateurin
requested changes
Jan 20, 2026
This might also improve a bit the performance. Signed-off-by: Carl Schwan <carlschwan@kde.org>
c1575e9 to
c8989d8
Compare
provokateurin
approved these changes
Jan 27, 2026
| * @since 9.1.0 | ||
| */ | ||
| public function setId($id); | ||
| public function setId(string $id): self; |
Member
There was a problem hiding this comment.
Despite the code comment this was int everywhere as you can see in your code and test adjustments…
It breaks Talk share provider according to CI in richdocuments…
So this should receive a proper documentation PR and if possible we allow int for the time being and cast to string?
Member
There was a problem hiding this comment.
Also breaking in deck it seems
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This might also improve a bit the performance as we are spending 2-3% of CPU time in
IShare::setIdTODO
Checklist
3. to review, feature component)stable32)