fix: do not truncate birth year to 1970#57017
Merged
Conversation
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
/backport to stable31 |
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
02f5a31 to
7c266d9
Compare
Member
|
Does this work without #57018? |
Contributor
Author
Yes, it still works, the first occurrence timestamp is just zeroed out. The event is saved but not discoverable in the calendar before 1970. |
Member
|
That sounds like a good and practical solution. I doubt anyone will actually look for the event 70 years ago. |
ChristophWurst
approved these changes
Dec 12, 2025
kesselb
approved these changes
Dec 12, 2025
This was referenced Dec 12, 2025
Member
|
This unfortunately breaks the unit tests on 32bits system https://github.com/nextcloud/server/actions/runs/20240455606/job/58106854965?pr=57099 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before
Now
Checklist
3. to review, feature component)stable32)