Skip to content

Port systemtags to Snowflake ids#56183

Open
CarlSchwan wants to merge 3 commits intomasterfrom
carl/cleanup-systemtags
Open

Port systemtags to Snowflake ids#56183
CarlSchwan wants to merge 3 commits intomasterfrom
carl/cleanup-systemtags

Conversation

@CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Nov 4, 2025

  • First commit: just some cleanup
  • Second commit: actual port

Ref #56045

Checklist

@CarlSchwan CarlSchwan requested a review from a team as a code owner November 4, 2025 11:27
@CarlSchwan CarlSchwan requested review from ArtificialOwl, icewind1991, leftybournes and yemkareems and removed request for a team November 4, 2025 11:27
@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Nov 4, 2025
@CarlSchwan CarlSchwan mentioned this pull request Nov 4, 2025
Open
13 tasks
@CarlSchwan CarlSchwan force-pushed the carl/cleanup-systemtags branch from 207a3e3 to d19d1e2 Compare November 4, 2025 11:28
@AndyScherzinger
Copy link
Member

AndyScherzinger commented Nov 4, 2025

adding @marcelklehr since I can't tell if this impacts files_confidental or recognize in any way

@CarlSchwan CarlSchwan force-pushed the carl/cleanup-systemtags branch 2 times, most recently from bf088fc to 7da202b Compare November 6, 2025 10:53
marcelklehr
marcelklehr approved these changes Nov 10, 2025
View reviewed changes
Copy link
Member

@marcelklehr marcelklehr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like it's affecting recognize nor files_confidential 👍

@CarlSchwan CarlSchwan force-pushed the carl/cleanup-systemtags branch from 7da202b to b47bb37 Compare November 11, 2025 14:39
@CarlSchwan CarlSchwan force-pushed the carl/cleanup-systemtags branch from b47bb37 to 283379a Compare November 12, 2025 15:29
@CarlSchwan CarlSchwan requested a review from a team as a code owner November 12, 2025 15:29
@CarlSchwan CarlSchwan requested review from nfebe, sorbaugh and susnux and removed request for a team November 12, 2025 15:29
@CarlSchwan CarlSchwan force-pushed the carl/cleanup-systemtags branch 2 times, most recently from d717b01 to c72e656 Compare November 12, 2025 15:48
@CarlSchwan
refactor(systemtags): Cleanup system tags
ce3844d 
- Add override annotation
- Use fn functions
- Use command enums

Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
@CarlSchwan
refactor(systemtags): Port to snowflake ids
e83be80 
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
@CarlSchwan
chore: recompile assets
af3cf48 
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
@CarlSchwan CarlSchwan force-pushed the carl/cleanup-systemtags branch from c72e656 to af3cf48 Compare November 17, 2025 09:24
@CarlSchwan CarlSchwan mentioned this pull request Nov 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcelklehr marcelklehr marcelklehr approved these changes

@blizzz blizzz blizzz approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

@susnux susnux Awaiting requested review from susnux susnux is a code owner automatically assigned from nextcloud/server-frontend

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-frontend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-frontend

Assignees

No one assigned

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CarlSchwan @AndyScherzinger @marcelklehr @blizzz