fix: Make current folder non-clickable in breadcrumb path bar#56040
fix: Make current folder non-clickable in breadcrumb path bar#56040soham04 wants to merge 2 commits intonextcloud:masterfrom
Conversation
- Add isCurrent flag to identify last breadcrumb item - Disable 'to' prop and click handler for current directory - Current folder now appears as a label instead of clickable button - Fixes visual spacing issue with the New button Fixes nextcloud#55988
|
👋 Hi everyone, this is my first contribution to Nextcloud, so I want to make sure I’m testing things correctly. I made this fix and verified that it builds successfully in GitHub Codespaces (npm run build worked fine). Could you please share the recommended way to start the development environment for the server repo (e.g. via Docker or manual setup)? Thanks in advance! 🙏 |
|
Thank you for your PR! Its also marked as this in the title of the button ("reload current view"). See discussion: #55988 (comment) |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Description
Fixes the confusing UX issue where clicking the current folder in the breadcrumb path bar triggers a reload with a spinner that completes without any visible changes. This was especially confusing for new users who may not recognize it as a path bar.
Changes Made
isCurrentflag to identify the last breadcrumb (current directory)toprop for the current directory to make it non-navigabledisableDroplogic to use theisCurrentflagTesting
npm run buildin GitHub CodespacesImplementation Details
The fix uses a simple
isCurrentflag based on the breadcrumb's index position. WhenisCurrentis true:toprop is set toundefined(prevents navigation)undefined(prevents reload)Fixes #55988
cc @nextcloud/designers @marcoambrosini @kra-mo