perf(external-share): Port to Entity and use snowflake Ids by CarlSchwan · Pull Request #55369 · nextcloud/server

CarlSchwan · 2025-09-28T09:27:24Z

Port away from Files::buildNotExistingFileName
Use IUser and IGroup instead of plain string

Resolves: #

Summary

TODO

...

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)
Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
Milestone added for target branch/version (ex: 32.x for stable32)

lib/public/DB/IResult.php

apps/files_sharing/lib/Hooks.php

come-nc · 2025-09-28T20:06:06Z

According to integation tests you broke federated shares @CarlSchwan

apps/federatedfilesharing/lib/OCM/CloudFederationProviderFiles.php

apps/files_sharing/lib/External/Manager.php

apps/federatedfilesharing/lib/OCM/CloudFederationProviderFiles.php

apps/files_sharing/lib/External/Manager.php

lib/private/Activity/Event.php

apps/files_sharing/lib/Controller/RemoteController.php

- Port away from Files::buildNotExistingFileName - Use IUser and IGroup instead of plain string Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>

Move the functionality in the last place it is used OC\Files\Node\Folder Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>

Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>

This might fixes the test. Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>

Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>

This removes all the read after write and we don't need to queries all the time the same share in the same request anymore. Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>

Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>

We always been returning an int for for accepted, but since it was returned as a mixed from the DB, psalm never complained about the fact this was typed as a bool in the API doc. Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>

API change for snowflake-ids are allowed as long as documented

CarlSchwan added this to the Nextcloud 33 milestone Sep 28, 2025

CarlSchwan self-assigned this Sep 28, 2025

CarlSchwan requested a review from a team as a code owner September 28, 2025 09:27

CarlSchwan requested review from Altahrim, icewind1991 and salmart-dev and removed request for a team September 28, 2025 09:27

CarlSchwan added the 3. to review Waiting for reviews label Sep 28, 2025

CarlSchwan requested a review from come-nc September 28, 2025 09:28

CarlSchwan force-pushed the carl/cleanup-external-manager branch 2 times, most recently from c3a408f to 0c9834a Compare September 28, 2025 10:01

CarlSchwan added technical debt ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) feature: sharing labels Sep 28, 2025

come-nc reviewed Sep 28, 2025

View reviewed changes

lib/public/DB/IResult.php Outdated Show resolved Hide resolved

CarlSchwan force-pushed the carl/cleanup-external-manager branch from 0c9834a to 4b5ed3f Compare September 28, 2025 10:20

come-nc approved these changes Sep 28, 2025

View reviewed changes

CarlSchwan force-pushed the carl/cleanup-external-manager branch from 4b5ed3f to 853ea64 Compare September 28, 2025 10:54

Altahrim approved these changes Sep 28, 2025

View reviewed changes

apps/files_sharing/lib/Hooks.php Show resolved Hide resolved

CarlSchwan force-pushed the carl/cleanup-external-manager branch 2 times, most recently from 04fd1d0 to 05935e0 Compare September 29, 2025 10:00

come-nc reviewed Sep 29, 2025

View reviewed changes

apps/federatedfilesharing/lib/OCM/CloudFederationProviderFiles.php Outdated Show resolved Hide resolved

apps/files_sharing/lib/External/Manager.php Outdated Show resolved Hide resolved

CarlSchwan force-pushed the carl/cleanup-external-manager branch 2 times, most recently from c1e8ffc to 46c8632 Compare September 30, 2025 08:24