fix: check if reported size is numeric in file info command

[st3iny]

• Resolves: #

Summary

The stat array will contain a 'size' member if S3 is used as primary storage. However, it will be empty leading to confusing error messages: warning: object had a size of but cache entry has a size of 59. This should have been automatically repaired

(See how there is no actual size mentioned after size of.)

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[st3iny]

Error: core/Command/Info/File.php:179:10: RedundantCondition: Type int for $stat['size'] is always numeric (see https://psalm.dev/122)

No, it is not ...

[kesselb]

fyi #54919

[kesselb]

Error: core/Command/Info/File.php:179:10: RedundantCondition: Type int for $stat['size'] is always numeric (see https://psalm.dev/122)

No, it is not ...

https://github.com/JetBrains/phpstorm-stubs/blob/d74d654cf966aaa56fd508c1f727c46313903aa2/standard/standard_7.php#L779-L795

I guess you have to ignore or add to the baseline.

server/lib/private/Files/ObjectStore/ObjectStoreStorage.php

Line 215 in 88077c4

public function stat(string $path): array|false {

Or ensure that we are not returning an invalid size here. Probably it's just the data from CacheEntry forwarded without validation.

[st3iny]

Thanks, then it is fixed already. I was confused why it would print even if we check for is_set() already. Now it makes sense.

Closing in favor of #54919.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)