Conversation
7ac9df5 to
bd5c8ce
Compare
marcelklehr
reviewed
Sep 4, 2025
|
|
||
| $this->availableTaskTypes = $availableTaskTypes; | ||
| $this->distributedCache->set('available_task_types_v2', serialize($this->availableTaskTypes), 60); | ||
| $this->distributedCache->set(self::TASK_TYPES_CACHE_KEY, serialize($this->availableTaskTypes), 60); |
marcelklehr
reviewed
Sep 4, 2025
| new ServiceRegistration('test', BrokenSyncProvider::class) | ||
| ]); | ||
| self::assertCount(1, $this->manager->getAvailableTaskTypes()); | ||
| self::assertCount(1, $this->manager->getAvailableTaskTypeIds()); |
bd5c8ce to
65863d6
Compare
Merged
Member
Author
|
@nickvergessen This addresses the performance hit because of the model retrieval when computing the capabilities. Should we backport this up to 30? |
Member
|
/backport to stable32 |
… task type IDs Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
65863d6 to
1775c94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some consumers of this API get the list of available task types with
manager->getAvailableTaskTypeswhich gives a full description of the task types, including the list of values for the enum input parameters. These values can be slow to compute, slowing down the process when they might not be needed.This new method just get the list of available task type IDs.
Checklist