fix(lexicon): send single notice/warning when using unknown config key#54739
Merged
provokateurin merged 1 commit intomasterfrom Sep 2, 2025
Merged
fix(lexicon): send single notice/warning when using unknown config key#54739provokateurin merged 1 commit intomasterfrom
provokateurin merged 1 commit intomasterfrom
Conversation
Member
provokateurin
left a comment
There was a problem hiding this comment.
Can you use some other key than the literal log message? 🙈
Member
Author
|
I had the same thought; the solution i had in mind was to send at least the key, or the app+key string, to the method and use it as index. adding some complexity to the code. And doing a checksum was overkill. My own conclusion was that, at the same time, the code is deep into the loop and should not be executed that much. But yes, I can; should I ? |
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
8f0e0b3 to
46ced9d
Compare
Member
Author
|
provokateurin
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, if an app set the Lexicon Strictness to
NOTICEorWARNING, 9 duplicate logs entries are generated when usingReason for that is that the key is used multiple time in the process.
The fix is to only print once and filters all similar reports