chore: remove all mbstring.func_overload references#53578
Merged
Conversation
artonge
approved these changes
Jun 18, 2025
skjnldsv
approved these changes
Aug 20, 2025
Member
|
Conflicts :/ |
solracsf
approved these changes
Aug 21, 2025
come-nc
approved these changes
Aug 21, 2025
74d9278 to
6c1a54d
Compare
Contributor
|
Rebased and solved conflicts |
Member
|
Related |
Contributor
|
I do not know what’s the correct way to update those hashes. @nickvergessen You’re the last one to touch those hashes (6 years ago 🙈 ), do you know what’s to do? |
Deprecated in PHP 7.2 Removed in PHP 8.0 https://www.php.net/manual/en/mbstring.configuration.php#ini.mbstring.func-overload Signed-off-by: Josh <josh.t.richards@gmail.com>
Deprecated in PHP 7.2 Removed in PHP 8.0 https://www.php.net/manual/en/mbstring.configuration.php#ini.mbstring.func-overload Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
…ntent Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
978fa7f to
4082a45
Compare
Member
|
Just to have it "documented"
Dummy thought is: server/tests/lib/IntegrityCheck/CheckerTest.php Lines 734 to 738 in b7c1594 But what I did was: server/tests/lib/IntegrityCheck/CheckerTest.php Lines 603 to 605 in b7c1594 Print actual values. Update the hash (L588) and signature (L591) in this test and use the same values in testVerifyCoreSignatureWithValidModifiedHtaccessSignatureData
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist