Drop unused jquery multiselect widget#53113
Drop unused jquery multiselect widget#53113elchukc wants to merge 2 commits intonextcloud:masterfrom
Conversation
Signed-off-by: Clare Elchuk <clareelchuk@gmail.com>
Signed-off-by: Clare Elchuk <clareelchuk@gmail.com>
6184d57 to
403462e
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
Thank you for the PR, this was resolved mostly in the meantime when we migrated user_ldap to Vue. |
Summary
Removes 4 out of 5 uses of jquery-ui highlighted in #12980. The last one was a tooltip that was deleted in PR#37244.
I did my best to remove all jquery-ui uses in
user_ldap/but jquery is unfamiliar to me and it's hard to tell if I'm missing anything.After a bunch of digging around in the documentation, I still cannot get any of the automated tests or php linting to work, although did run
npm run lint:fixTODO
Checklist