fix(files_sharing): bring back handling of hide-download on public shares#52180
Merged
fix(files_sharing): bring back handling of hide-download on public shares#52180
hide-download on public shares#52180Conversation
szaimen
reviewed
Apr 14, 2025
2bf2439 to
3401468
Compare
artonge
reviewed
Apr 14, 2025
artonge
reviewed
Apr 14, 2025
artonge
approved these changes
Apr 14, 2025
Contributor
Author
|
/backport to stable31 |
Contributor
Author
36 tasks
danxuliu
reviewed
Apr 16, 2025
Member
danxuliu
left a comment
There was a problem hiding this comment.
yes that covered by the webdav property
As the hideDownload element is no longer provided please note that this pull request alone is not enough to bring back the old behaviour. Any app that used the hideDownload element must be updated to get the value from the new WebDAV property instead (so this should be documented somewhere).
For the PDF viewer I adjusted it in the last commit of nextcloud/files_pdfviewer#1164
…e of shares Signed-off-by: Ferdinand Thiessen <[email protected]>
… action Signed-off-by: Ferdinand Thiessen <[email protected]>
… enabled Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Contributor
Author
|
PR to viewer will be created right after merge |
Signed-off-by: Ferdinand Thiessen <[email protected]>
3401468 to
e5291ca
Compare
2 tasks
This was referenced Apr 27, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This includes also some features as we need a WebDAV property for the
hide-downloadfunctionality,in legacy sharing interface it was passed as some kind of state, but with the Vue files interface we need a node attribute.
Best to review each commit separately.
Checklist