[stable29] [stable30] fix(SharingEntryLink): Show default password before create if any#50883
Closed
backportbot[bot] wants to merge 2 commits intostable29from
Closed
[stable29] [stable30] fix(SharingEntryLink): Show default password before create if any#50883backportbot[bot] wants to merge 2 commits intostable29from
backportbot[bot] wants to merge 2 commits intostable29from
Conversation
Prevent silent addition of expiration date to shares. Prevent silent addition for password to shares. Both now have a `shareRequiresReview` check Resolves : #48860 Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com> [skip ci]
Contributor
|
Small diff (which we have updated and changed anyways), other changes from the initial PR present in 29 which means I (or someone else had backported this manually). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #49149
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.