fix(ConvertType): Read dbtype in createConnectionParams and remove safeguard#50530
Merged
provokateurin merged 2 commits intomasterfrom Jan 30, 2025
Merged
fix(ConvertType): Read dbtype in createConnectionParams and remove safeguard#50530provokateurin merged 2 commits intomasterfrom
provokateurin merged 2 commits intomasterfrom
Conversation
5 tasks
Member
Author
|
/backport to stable31 |
Member
Author
|
/backport to stable30 |
Member
Author
|
/backport to stable29 |
solracsf
reviewed
Jan 29, 2025
nfebe
reviewed
Jan 30, 2025
Contributor
nfebe
left a comment
There was a problem hiding this comment.
Are the any auto tests for this?
Member
Author
No unfortunately not, as changing the DB inside the tests is not a good idea. I still want to add a test for it later though, but will have to see in what form. |
…feguard Signed-off-by: Nils Wenninghoff <nils@ungemein.cool>
Signed-off-by: provokateurin <kate@provokateurin.de>
1ce1990 to
d8cc8aa
Compare
come-nc
approved these changes
Jan 30, 2025
nfebe
approved these changes
Jan 30, 2025
This was referenced Jan 30, 2025
Merged
4 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #45257
Unforked version of #48666.
While testing I also found that #39242 read the hostname wrong which never worked.
I tested it successfully like this (make sure to have
pdo_pgsqlenabled):Checklist