Skip to content

feat(systemtags): add color support#49295

Merged
skjnldsv merged 7 commits intomasterfrom
feat/tags-colors
Dec 6, 2024
Merged

feat(systemtags): add color support#49295
skjnldsv merged 7 commits intomasterfrom
feat/tags-colors

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Nov 14, 2024 •
edited
Loading

fix #6778
WIP

In progress

  • Add color backend support
  • Add bulk tagging UI color support
  • Add inline tags color support

Screenshot

image

@skjnldsv skjnldsv added enhancement design Design, UI, UX, etc. 2. developing Work in progress feature: tags labels Nov 14, 2024
@skjnldsv skjnldsv added this to the Nextcloud 31 milestone Nov 14, 2024
@skjnldsv skjnldsv self-assigned this Nov 14, 2024
@skjnldsv

This comment was marked as resolved.

Sign in to view
@skjnldsv skjnldsv force-pushed the feat/systemtags-bulk-create-list branch from 51a2dff to 99a7346 Compare November 15, 2024 10:10
@skjnldsv skjnldsv force-pushed the feat/tags-colors branch 4 times, most recently from a0248a7 to 6bf50f7 Compare November 15, 2024 10:13
Base automatically changed from feat/systemtags-bulk-create-list to master November 15, 2024 11:03
jancborchardt
jancborchardt approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very very nice! I have no feedback. @marcoambrosini?

jancborchardt
jancborchardt previously requested changes Nov 20, 2024
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment •
edited by skjnldsv
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry actually I do have 2 pieces of feedback :D

  • The popover seems to be very slightly misaligned to the left:
    Screenshot From 2024-11-20 14-10-17
  • There is a stray triangle here:
    image

@marcoambrosini

This comment was marked as resolved.

Sign in to view
@skjnldsv

This comment was marked as resolved.

Sign in to view
@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 21, 2024 •
edited
Loading

@jancborchardt There is also the inline tag display missing on this PR.
But I read many of your comments on the topic from here and here

I'll keep them like they are right now, no background and color the text+border only, following the WCAG contrast of course.

Quick example (careful, contrast hasn't been calculated, this is just a mockup)
image

@skjnldsv skjnldsv force-pushed the feat/tags-colors branch 5 times, most recently from 1f51a54 to c6bd30d Compare December 4, 2024 16:53
@skjnldsv skjnldsv requested review from a team, artonge, jancborchardt and susnux and removed request for a team December 4, 2024 17:01
@skjnldsv skjnldsv marked this pull request as ready for review December 4, 2024 19:12
marcelklehr
marcelklehr reviewed Dec 5, 2024
View reviewed changes
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 6, 2024
@skjnldsv skjnldsv enabled auto-merge December 6, 2024 08:13
@skjnldsv
feat(systemtags): add color support backend
adf8a45 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
feat(systemtags): add colors in bulk tagging action
cb472be 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
fix(systemtags): fix elementColor computation
4af365d 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
feat(systemtags): allow setting color with occ
0c7e259 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
chore(systemtags): add inline tag color tests
18d7d3b 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
chore: compile assets
d114646 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
fix(systemtags): handle null dav value
885b692 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv merged commit 9684c3d into master Dec 6, 2024
@skjnldsv skjnldsv deleted the feat/tags-colors branch December 6, 2024 09:43
@tobiasKaminsky tobiasKaminsky mentioned this pull request Dec 6, 2024
Closed
2 tasks
@disaster123
Copy link

disaster123 commented Dec 6, 2024

Thanks a lot for this. What is the planend release Version?

@marcelklehr
Copy link
Member

marcelklehr commented Dec 7, 2024

@disaster123 Nextcloud 31 Hub 10

@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Merged
@joshtrichards joshtrichards mentioned this pull request Jul 28, 2025
Closed
8 tasks
@icewind1991 icewind1991 mentioned this pull request Jul 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcelklehr marcelklehr marcelklehr approved these changes

@artonge artonge artonge approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@susnux susnux Awaiting requested review from susnux susnux is a code owner automatically assigned from nextcloud/server-frontend

@szaimen szaimen Awaiting requested review from szaimen szaimen is a code owner automatically assigned from nextcloud/server-frontend

@Antreesy Antreesy Awaiting requested review from Antreesy Antreesy is a code owner

Assignees

@skjnldsv skjnldsv

Labels

4. to release Ready to be released and/or waiting for tests to finish design Design, UI, UX, etc. enhancement feature: tags

Projects

None yet

Milestone

Nextcloud 31

Development

Successfully merging this pull request may close these issues.

colored tags

6 participants

@skjnldsv @marcoambrosini @disaster123 @marcelklehr @jancborchardt @artonge