chore: Add parameter type hints to parameters

[nickvergessen]

• Resolves: #

Summary

TODO

• ...

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[ChristophWurst]

👍 except for the structures that are possibly implemented/extended by apps

[skjnldsv]

Status ? :)

[provokateurin]

I think we should also be able to do this with rector which would save a lot of work

[nickvergessen]

But rector can not not do parameters only in classes and return types only on interfaces.

[miaulalala]

👏

[come-nc]

🧹

[skjnldsv]

Still many issues

{
  "Exception": "Exception",
  "Message": "OCP\\AppFramework\\Controller::getResponderByHTTPHeader(): Argument #2 ($default) must be of type string, null given, called in /home/runner/work/server/server/lib/private/AppFramework/Http/Dispatcher.php on line 219 in file '/home/runner/work/server/server/lib/public/AppFramework/Controller.php' line 95",
  "Code": 0,
  "Trace": [
    {
      "file": "/home/runner/work/server/server/lib/private/AppFramework/App.php",
      "line": 161,
      "function": "dispatch",
      "class": "OC\\AppFramework\\Http\\Dispatcher",
      "type": "->",
      "args": [
        {
          "__class__": "OCA\\Testing\\Controller\\ConfigController"
        },
        "deleteAppValue"
      ]
    },
    {
      "file": "/home/runner/work/server/server/lib/private/Route/Router.php",
      "line": 321,
      "function": "main",
      "class": "OC\\AppFramework\\App",
      "type": "::",
      "args": [
        "OCA\\Testing\\Controller\\ConfigController",
        "deleteAppValue",
        {
          "__class__": "OC\\AppFramework\\DependencyInjection\\DIContainer"
        },
        {
          "appid": "core",
          "configkey": "shareapi_enabled",
          "_route": "ocs.testing.config.deleteappvalue"
        }
      ]
    },
    {
      "file": "/home/runner/work/server/server/ocs/v1.php",
      "line": 61,
      "function": "match",
      "class": "OC\\Route\\Router",
      "type": "->",
      "args": [
        "/ocsapp/apps/testing/api/v1/app/core/shareapi_enabled"
      ]
    }
  ],
  "File": "/home/runner/work/server/server/lib/private/AppFramework/Http/Dispatcher.php",
  "Line": 150,
  "Previous": {
    "Exception": "TypeError",
    "Message": "OCP\\AppFramework\\Controller::getResponderByHTTPHeader(): Argument #2 ($default) must be of type string, null given, called in /home/runner/work/server/server/lib/private/AppFramework/Http/Dispatcher.php on line 219",
    "Code": 0,
    "Trace": [
      {
        "file": "/home/runner/work/server/server/lib/private/AppFramework/Http/Dispatcher.php",
        "line": 219,
        "function": "getResponderByHTTPHeader",
        "class": "OCP\\AppFramework\\Controller",
        "type": "->",
        "args": [
          "",
          null
        ]
      },
      {
        "file": "/home/runner/work/server/server/lib/private/AppFramework/Http/Dispatcher.php",
        "line": 118,
        "function": "executeController",
        "class": "OC\\AppFramework\\Http\\Dispatcher",
        "type": "->",
        "args": [
          {
            "__class__": "OCA\\Testing\\Controller\\ConfigController"
          },
          "deleteAppValue"
        ]
      },
      {
        "file": "/home/runner/work/server/server/lib/private/AppFramework/App.php",
        "line": 161,
        "function": "dispatch",
        "class": "OC\\AppFramework\\Http\\Dispatcher",
        "type": "->",
        "args": [
          {
            "__class__": "OCA\\Testing\\Controller\\ConfigController"
          },
          "deleteAppValue"
        ]
      },
      {
        "file": "/home/runner/work/server/server/lib/private/Route/Router.php",
        "line": 321,
        "function": "main",
        "class": "OC\\AppFramework\\App",
        "type": "::",
        "args": [
          "OCA\\Testing\\Controller\\ConfigController",
          "deleteAppValue",
          {
            "__class__": "OC\\AppFramework\\DependencyInjection\\DIContainer"
          },
          {
            "appid": "core",
            "configkey": "shareapi_enabled",
            "_route": "ocs.testing.config.deleteappvalue"
          }
        ]
      },
      {
        "file": "/home/runner/work/server/server/ocs/v1.php",
        "line": 61,
        "function": "match",
        "class": "OC\\Route\\Router",
        "type": "->",
        "args": [
          "/ocsapp/apps/testing/api/v1/app/core/shareapi_enabled"
        ]
      }
    ],
    "File": "/home/runner/work/server/server/lib/public/AppFramework/Controller.php",
    "Line": 95
  },
  "message": "OCP\\AppFramework\\Controller::getResponderByHTTPHeader(): Argument #2 ($default) must be of type string, null given, called in /home/runner/work/server/server/lib/private/AppFramework/Http/Dispatcher.php on line 219 in file '/home/runner/work/server/server/lib/public/AppFramework/Controller.php' line 95",
  "exception": {},
  "CustomMessage": "OCP\\AppFramework\\Controller::getResponderByHTTPHeader(): Argument #2 ($default) must be of type string, null given, called in /home/runner/work/server/server/lib/private/AppFramework/Http/Dispatcher.php on line 219 in file '/home/runner/work/server/server/lib/public/AppFramework/Controller.php' line 95"
}```