fix: gracefully handle unexpected exif orientation types#47509
Merged
fix: gracefully handle unexpected exif orientation types#47509
Conversation
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Member
Author
|
/backport to stable30 |
Member
Author
|
/backport to stable29 |
Member
Author
|
/backport to stable28 |
kesselb
approved these changes
Aug 27, 2024
joshtrichards
approved these changes
Aug 27, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
/backport to stable29 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The member
$exif['Orientation']is a string sometimes which breaks generating previews. I added some code to make it more robust and cast it to an int if the orientation is numeric.TODO
Checklist