Conversation
eb80c73 to
4c91f19
Compare
Antreesy
reviewed
Jul 30, 2024
ShGKme
requested changes
Jul 30, 2024
Contributor
|
A bit sad part is that 15 doesn't scale well in int numbers... It makes a text element having 22.5 height, which may result in some side effects. (It is different from 22 or 23 px) Having also grid baseline 16px, shouldn't we make font-size also 16, so it multiplies by 1.5 well, and lies on |
Contributor
This will cause some visual regressions (because some elements are fixed to the size), not sure if this would be too late for current release? |
Merged
Since we have different font sizes, we should make the line height dependent on the font size and not a fixed value. The recommended value for accessibility is 1.5. https://www.w3.org/WAI/WCAG21/Understanding/text-spacing.html Signed-off-by: Marco Ambrosini <marcoambrosini@proton.me>
4c91f19 to
e537728
Compare
ShGKme
approved these changes
Jul 31, 2024
Antreesy
approved these changes
Jul 31, 2024
Merged
3 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we have different font sizes, we should make the line height
dependent on the font size and not a fixed value. The recommended
value for accessibility is 1.5em.
https://www.w3.org/WAI/WCAG21/Understanding/text-spacing.html